Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs for datetime units show incorrect time spans #6711

Closed
clwainwright opened this issue Nov 21, 2015 · 5 comments
Closed

docs for datetime units show incorrect time spans #6711

clwainwright opened this issue Nov 21, 2015 · 5 comments

Comments

@clwainwright
Copy link

This can be seen in http://docs.scipy.org/doc/numpy/reference/arrays.datetime.html#datetime-units

The correct time spans should be:

s   second      +/- 2.9e11 years    [2.9e11 BC, 2.9e11 AD]
ms  millisecond +/- 2.9e8 years     [ 2.9e8 BC, 2.9e8 AD]
us  microsecond +/- 2.9e5 years     [290301 BC, 294241 AD]
ns  nanosecond  +/- 292 years       [  1678 AD, 2262 AD]

rather than

s   second      +/- 2.9e12 years    [ 2.9e9 BC, 2.9e9 AD]
ms  millisecond +/- 2.9e9 years     [ 2.9e6 BC, 2.9e6 AD]
us  microsecond +/- 2.9e6 years     [290301 BC, 294241 AD]
ns  nanosecond  +/- 292 years       [ 1678 AD, 2262 AD]
@badhrink
Copy link
Contributor

badhrink commented Jun 9, 2016

I know it has been a while since this has been reported. I was fishing for my first Open Source Contribution. Is it ok if I take this up?

@shoyer
Copy link
Member

shoyer commented Jun 9, 2016

Yes, this would be a good choice for a first contribution!

@badhrink
Copy link
Contributor

Ok, this is embarassing. I made changes to the text(using the edit option in the github) in doc/source/reference/arrays.datetime.rst.

I made a pull request (#7721). Soon after that some auto build happened and two builds failed. I got this error "Specify a project or solution file. The directory does not contain a project or solution file."

Where did I go wrong?

@shoyer
Copy link
Member

shoyer commented Jun 10, 2016

Take a look at the contributing guidelines: https://github.com/numpy/numpy/blob/master/CONTRIBUTING.md (and links there-in)

It's a little more work to set started, but I think it's definitely worthwhile to get git setup properly on your computer.

@charris
Copy link
Member

charris commented Jun 10, 2016

I don't recommend that approach for the back and forth typical of numpy PRs, but noticed that the PR was against 1.7.x rather than master. Recently testing against older branches seems to fail, possibly because of changes in the travis tester and also the fact that appveyor is newer.

badhrink added a commit to badhrink/numpy that referenced this issue Jun 10, 2016
Changed/corrected Time span - relative and absolute - for second, millisecond and microsecond. 

There were slight differences and was noted duly in the issue. See numpy#6711 (numpy#6711)
@charris charris closed this as completed Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants