Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For 2.0.0rc1 pp39 windows wheel fails test collection #26178

Open
charris opened this issue Mar 30, 2024 · 6 comments
Open

For 2.0.0rc1 pp39 windows wheel fails test collection #26178

charris opened this issue Mar 30, 2024 · 6 comments

Comments

@charris
Copy link
Member

charris commented Mar 30, 2024

See https://github.com/numpy/numpy/actions/runs/8485561340/job/23252932520. The relevant error seems to be

ERROR f2py/tests/test_abstract_interface.py - PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmp5xhejvww\\meson.build'

NumPy v2.0.0b1 built and tested without problems and very little has changed. The only thing that might be suspicious is the upgrade of pypa/cibuildwheel, and the wheel built without problems, and I am not sure why that would affect meson using the file. The other candidate might be pytest-xdist, but it hasn't changed.

I am tempted to ignore this for the 2.0.0rc1 release, I don't think it is a blocker.

@charris charris added this to the 2.0.0 release milestone Mar 30, 2024
@charris
Copy link
Member Author

charris commented Mar 30, 2024

That last wheel build for main ran without problems 3 days ago. I suppose this could be affected by the same problem that has impacted emscripten.

@mattip
Copy link
Member

mattip commented Mar 30, 2024

Skipping it is fine. If we figure it out we can upload rhe wheel later

@charris
Copy link
Member Author

charris commented Mar 30, 2024

Took 4 tries, but eventually the pp39 wheel test did run. Looking back, the 2.0.0b1 release took 3 tries.

@mattip
Copy link
Member

mattip commented Apr 3, 2024

We have seen some problems with test collection caused by a garbage collection bug. Much of the problem has been fixed and will be part of the next release. See the issue and a blog post about it.

@charris
Copy link
Member Author

charris commented Apr 3, 2024

@mattip We should drop Python 3.9 for NumPy 2.1, is there any problem with PyPy on that platform?

@mattip
Copy link
Member

mattip commented Apr 3, 2024

PyPy 3.9 and 3.10 share as much as possible of the same code base, so new problems would be unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants