Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: NPY_ITER_BUFFERED is set on ufunc reductions, causing bufferred iteration #17649

Closed
mattip opened this issue Oct 27, 2020 · 2 comments
Closed

BUG: NPY_ITER_BUFFERED is set on ufunc reductions, causing bufferred iteration #17649

mattip opened this issue Oct 27, 2020 · 2 comments

Comments

@mattip
Copy link
Member

mattip commented Oct 27, 2020

Even if there is no need, PyUFunc_ReduceWrapper unilaterally add the NPY_ITER_BUFFERED flag to iteration here and iterator_loop adds it here. This breaks up the iteration into np.getbuffersize()` chunks, slowing down iteration. xref this comment.
@seberg
Copy link
Member

seberg commented Oct 27, 2020

I suppose this is the same issue as gh-17471?

@mattip
Copy link
Member Author

mattip commented Oct 27, 2020

Ahh, right. I couldn't find the issue because I searched for NPY_ITER_BUFFERED, but the flag is NPY_ITFLAG_BUFFER

@mattip mattip closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seberg @mattip