Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dark mode #707

Open
4 tasks
jarrodmillman opened this issue Dec 7, 2023 · 13 comments
Open
4 tasks

Enable dark mode #707

jarrodmillman opened this issue Dec 7, 2023 · 13 comments

Comments

@jarrodmillman
Copy link
Member

Here is a partial list of issues that need to be addressed:

  • Undo a856374
  • Logos not rendering well in dark mode (scientific domains; sponsorships on About)
  • Tabs: last two tabs seem to have rendering problems; also check dark mode
    color
  • Language drop down: wrong color in dark mode (should be fixed in theme?)
@brahmbeyond
Copy link

brahmbeyond commented Dec 7, 2023

Here is a partial list of issues that need to be addressed:

  • Undo a856374
  • Logos not rendering well in dark mode (scientific domains; sponsorships on About)
  • Tabs: last two tabs seem to have rendering problems; also check dark mode
    color
  • Language drop down: wrong color in dark mode (should be fixed in theme?)

@jarrodmillman sir in order to see this issue I tried to run the code , followed all the steps to install it and started the sever , got this error
Error: error building site: assemble: "/workspaces/numpy-test/content/pt/teams.md:8:1": failed to extract shortcode: template for shortcode "include-html" not found

checked there was no include-html.html file inside shortcodes folder.

How can I solve this to proceed further.

Runnnig on github Codespaces.
Hugo version -hugo v0.120.4-f11bca5fec2ebb3a02727fb2a5cfb08da96fd9df linux/amd64 BuildDate=2023-11-08T11:18:07Z VendorInfo=gohugoio

@alphapapa
Copy link
Contributor

Addressing in #708

alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this issue Dec 7, 2023
@brahmbeyond
Copy link

Addressing in #708

Ok , but what might be the issue causing error in mine !?

@alphapapa

This comment was marked as off-topic.

@alphapapa
Copy link
Contributor

@jarrodmillman Do you still want to set the text color of the selected tab to match the unselected tabs, as it was before importing PDST, or do you want to keep it as PDST does it?

Screenshots

PDST style, as-is:
localhost_1313_

Text matching other tabs:
localhost_1313_ (1)

@stefanv
Copy link
Contributor

stefanv commented Dec 8, 2023

Fine the way PDST does it.

stefanv pushed a commit to scientific-python/scientific-python-hugo-theme that referenced this issue Dec 8, 2023
@brahmbeyond
Copy link

@autumn-absconds This issue is for addressing the stated bugs. What are you trying to do, and why? i.e. are you trying to deploy the numpy.org Web site yourself, or...

I was trying to deploy myself to solve those bugs, read some guide earlier on how to start contributing to Open source , that's how it was to first clone and all that...

Till now I had used GitHub to store my small projects only ,
This is my first time trying to do something like this , is this wrong way ?

@alphapapa

This comment was marked as off-topic.

@brahmbeyond
Copy link

@autumn-absconds You are trying to learn about 20 things at once. I would suggest that you slow down, pick a project that you already use personally, and see if there's some small issue you can work on. This project has both volunteer and professional developers working on it, and we can't offer personal tutorials for new open source developers here on this issue report. If you need more help, perhaps you could contact the author of the guide you read, or look for some IRC channel to help new developers.

ok I'm sorry for that and Thank you for the advice! I really appreciate it.

@stefanv
Copy link
Contributor

stefanv commented Dec 8, 2023

@autumn-absconds Thank you for your interest in contributing! A great way to tip your toes into the water is to join a mentored sprint. In fact, I think some of those are coming up! Perhaps @InessaPawson knows when the next one is?

There are a lot of moving parts to contributing, but don't despair. It can take a while to find the right place to do work. As Adam said, it helps to work on a project you need/use. Then identify a small issue to work on, which will give you a chance to learn the contributing process.

Many projects in the ecosystem (scikit-image, networkx, etc.) have contributor guides that you can look at. But, again, a mentored sprint may be the easiest place to start.

Good luck on your open source journey!

@brahmbeyond
Copy link

@stefanv, thank you very much, sir, for your valuable advice and for suggesting the mentored sprint. I will certainly explore it. For now, I am addressing issues within my own projects that I had overlooked until now. I will first correct them before proceeding to the projects I use most frequently. Once again, thanks to both @alphapapa and @stefanv for your guidance.

@InessaPawson
Copy link
Member

@autumn-absconds Thank you for your interest in contributing! A great way to tip your toes into the water is to join a mentored sprint. In fact, I think some of those are coming up! Perhaps @InessaPawson knows when the next one is?

@autumn-absconds I second @stefanv that joining a newcomers sprint hosted by a project that you regularly use is a great way to start contributing to open source.

In the Python community, the sprints schedule for 2024 is still shaping up. I recommend reaching out to the projects you’re interested in contributing to and asking if they are hosting any events for newcomers in the near future.

@brahmbeyond
Copy link

Thank you @InessaPawson , I will surely look for and react out them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants