Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the headings on the landing page anchor links #552

Open
rossbar opened this issue Feb 2, 2022 · 10 comments
Open

Make the headings on the landing page anchor links #552

rossbar opened this issue Feb 2, 2022 · 10 comments

Comments

@rossbar
Copy link
Contributor

rossbar commented Feb 2, 2022

It would be nice if the top-level headings (e.g. Ecosystem, Case Studies) were anchor links so that people could link to a specific portion of the page without having to scroll to get there.

@stefanv
Copy link
Contributor

stefanv commented Feb 2, 2022

They are anchor links, we should just rewrite the URL when a user clicks on sidebar items so you know what IDs they are :)

https://scientific-python.org/ecosystem/#install

@rossbar
Copy link
Contributor Author

rossbar commented Feb 2, 2022

They are anchor links, we should just rewrite the URL when a user clicks on sidebar items so you know what IDs they are :)

I'm a bit confused by this because AFAICT the numpy.org landing page doesn't have a sidebar. I was thinking something more along the lines of the little chain-link icon that appears when you hover over a section heading in some themes. Whether it's adding a sidebar or some other approach, it'd be nice to be able to easily create those anchor links to the section headings in the browser!

@stefanv
Copy link
Contributor

stefanv commented Feb 3, 2022

This is addressed in scientific-python/scientific-python-hugo-theme#116

@stefanv
Copy link
Contributor

stefanv commented Feb 3, 2022

(I did not add the little chain-link icons, but it would be straightforward to do so, if desired.)

@jarrodmillman
Copy link
Member

See #553.

@rossbar
Copy link
Contributor Author

rossbar commented Feb 3, 2022

This is a nice improvement but it doesn't seem to apply to the landing page where there is no sidebar. AFAICT there's still no way to click on/near the ECOSYSTEM heading or CASE STUDIES headings for example.

@stefanv
Copy link
Contributor

stefanv commented Feb 3, 2022

Thanks for noticing those, I will fix them too!

EDIT: We can fix those in NumPy; since they're custom add-ins, we just have to make sure they have anchors specified as in:

<h2 id="this-heading-title">This Heading Title</h2>

If they use the hugo built-in mechanisms for generating headings, then headings automatically get IDs.

@tinaoberoi
Copy link

Hi everyone,
Is this issue still open? If yes would love to work on it.

@InessaPawson
Copy link
Member

@tinaoberoi, feel free to work on this issue.

@rossbar
Copy link
Contributor Author

rossbar commented Dec 21, 2022

Is this issue still open? If yes would love to work on it.

Yes please feel free. Note though that this may be better handled in the underlying scientific-python-hugo-theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants