Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail CI for warnings #154

Open
bsipocz opened this issue Nov 17, 2022 · 5 comments · Fixed by #203
Open

Fail CI for warnings #154

bsipocz opened this issue Nov 17, 2022 · 5 comments · Fixed by #203
Labels
enhancement New feature or request

Comments

@bsipocz
Copy link
Member

bsipocz commented Nov 17, 2022

Ideally we should handle warnings raised during the tutorials, and fail CI with anything that is unexpected.

@rossbar
Copy link
Collaborator

rossbar commented Nov 18, 2022

Good point! I though we had this covered with the -W option for sphinx-build, but it turns out that doesn't extend to warnings raised during notebook execution.

@rossbar rossbar added the enhancement New feature or request label Nov 18, 2022
@bsipocz
Copy link
Member Author

bsipocz commented Nov 18, 2022

yep, the code content and rendering are handled separately.

You can assign this to me, though I'm not sure when I get to actually do something about it.

@rossbar
Copy link
Collaborator

rossbar commented Nov 18, 2022

Of course - feel free! I also opened executablebooks/MyST-NB#459 about this as I couldn't find a good way to handle this at the config-level.

@bsipocz
Copy link
Member Author

bsipocz commented Nov 18, 2022

Of course - feel free

I can't do that ;)

I also opened executablebooks/MyST-NB#459 about this as I couldn't find a good way to handle this at the config-level.

Ideally, a standard pytest config should do the trick, but f course it doesn't work out of the box :(

@rossbar
Copy link
Collaborator

rossbar commented Jan 23, 2024

I'm going to go ahead and re-open this - #203 fixed the current batch of warnings, but I agree with the original premise that we need something in CI to fail on runtime warnings.

@rossbar rossbar reopened this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants