Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need more thorough test coverage #58

Open
Kai-Striega opened this issue Oct 23, 2022 · 5 comments
Open

We need more thorough test coverage #58

Kai-Striega opened this issue Oct 23, 2022 · 5 comments
Labels
good first issue Issues that are suitable for beginners or newcomers help wanted Extra attention is needed
Milestone

Comments

@Kai-Striega
Copy link
Member

Our tests for many of the functions are very sparse, this should be updated to include more tests for each of the functions in numpy-financial. In particular, I think we need more thorough testing of edge cases.

The test can be modified by editing test_financial.py.

@Kai-Striega
Copy link
Member Author

@jdilanzo I think you might be interested in this

@jlopezpena
Copy link
Contributor

Financial math functions are very amenable to property based testing, which excels at finding edge cases. Would it be acceptable to add a dev/test dependency on hypothesis? If so, I can give a hand at designing sampling strategies and property based tests.

@Kai-Striega
Copy link
Member Author

Hypothesis looks like a great addition. I'm happy to add it as a dev dependency. I don't have much experience with hypothesis, although I've been meaning to try it out for a while. So I might need a wile to get up to speed

@Kai-Striega
Copy link
Member Author

@kalicialopez You might be interested in this :)

@Kai-Striega Kai-Striega added help wanted Extra attention is needed good first issue Issues that are suitable for beginners or newcomers labels Nov 11, 2023
@Kai-Striega Kai-Striega added this to the 2.0 milestone Nov 11, 2023
@Kai-Striega
Copy link
Member Author

I've been thinking about this some more and, at a minimum, I'd like to confirm each function:

  • Supports decimal.Decimal type
  • Supports broadcasting behaviour

I'm also amicable to using hypothesis as suggested earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for beginners or newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants