Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs board not showing #32

Open
melissawm opened this issue Feb 7, 2023 · 13 comments
Open

Jobs board not showing #32

melissawm opened this issue Feb 7, 2023 · 13 comments

Comments

@melissawm
Copy link
Contributor

Currently, the jobs board is actually showing up as empty on https://jobs.numfocus.org/

Screenshot_20230207_163735

The console is showing a couple of errors:

Screenshot_20230207_163819

@stefanv
Copy link
Collaborator

stefanv commented Feb 7, 2023

There are no unexpired jobs! Maybe I should print a message when that is the case?

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Feb 7, 2023

To provide another data point, in FF 107.0.1 on Windows, I see the jobs briefly display successfully, but then the JS hits a couple of React errors and the jobs are no longer displayed:

Loading Loaded
image image

@stefanv
Copy link
Collaborator

stefanv commented Feb 7, 2023

Behavior is correct, if undesirable. I can have it filter first and then display.

See also #33

@melissawm
Copy link
Contributor Author

Oh I see! Thanks @stefanv !

@stefanv
Copy link
Collaborator

stefanv commented Feb 7, 2023

It's a good question, how those jobs ever slip by, because the code is:

  const jobs = filterJobs(jobData, formData);

and in filterJobs:

const filterJobs = (jobs, filter) => {
  // Filter out expired jobs.  Use Howland Island timezone to ensure
  // that everyone sees the job on its last day.
  const today = new Date();
  jobs = jobs.filter((job) => new Date(`${job.expires}T23:59:59.999-12:00`) > today);

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Feb 7, 2023

Also, from a UX perspective, the idiomatic pattern would be to always show some kind of message confirming that no open jobs are available instead of just a blank screen, which (as can be seen by the multiple responses here) is interpreted by users as abnormal behavior of unclear provenance.

@stefanv
Copy link
Collaborator

stefanv commented Feb 7, 2023

Check out the new page ;)

@psobolewskiPhD
Copy link

As one of the confused people by the blank page, the banner is great—thanks!
But from the other screenshots, it looks like the expired jobs are there somewhere, so maybe it could be possible to still browse them, just for curiousity/archival? Like a checkbox "expired" in the filter?

@stefanv
Copy link
Collaborator

stefanv commented Feb 7, 2023

Yes, all the jobs are there, since they receive permalinks. I can add a button to the search box to show expired posts as you suggest.

@stefanv
Copy link
Collaborator

stefanv commented Feb 7, 2023

@psobolewskiPhD There you go: #34

@psobolewskiPhD
Copy link

Love it! thanks!
Minor nitpick: I think there's a line break missing:
image

@stefanv
Copy link
Collaborator

stefanv commented Feb 7, 2023

They render side-by-side on a wide screen, and then start to wrap as the screen gets narrower. A simple bit of CSS would solve that, if someone wants to take a look.

@SahilSinghTomar
Copy link

we can decrease padding to the right so that full-time come in 1 line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants