Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Fix failing tests due to data changes #32

Open
jparyani opened this issue Jul 12, 2019 · 5 comments
Open

Fix failing tests due to data changes #32

jparyani opened this issue Jul 12, 2019 · 5 comments

Comments

@jparyani
Copy link
Contributor

See Travis for what's failing.

You can run tests locally by doing:

python ci/test-installed-numerox.py
@csp197
Copy link
Contributor

csp197 commented Jul 12, 2019

Hi @jparyani,
I'd like to help out with this issue.

How can I build this repo locally?

@jparyani
Copy link
Contributor Author

To install the local repo, all you have to do is run:

pip install -e .

After that succeeds, run:

python ci/test-installed-numerox.py

to see all the failing tests.

@csp197
Copy link
Contributor

csp197 commented Jul 13, 2019

There are 55 errors and 2 failures, and I've fixed the 2 failures.
I'm trying to resolve the errors now :)

csp197 added a commit to csp197/numerox that referenced this issue Jul 13, 2019
@csp197
Copy link
Contributor

csp197 commented Jul 13, 2019

@jparyani - I've added a commit which takes care of the failures, but there are still quite a bit of errors.
A lot of them deal with the ramifications of the new active kazutsugi tournament, as well as rendering the rest of the tournaments inactive.

@jparyani
Copy link
Contributor Author

Alright, if you’ve reached a good partial stopping point, feel free to create a PR.

jparyani added a commit that referenced this issue Jul 13, 2019
#32: Fixing Travis CI test failures
csp197 added a commit to csp197/numerox that referenced this issue Jul 26, 2019
csp197 added a commit to csp197/numerox that referenced this issue Jul 26, 2019
csp197 added a commit to csp197/numerox that referenced this issue Jul 27, 2019
csp197 added a commit to csp197/numerox that referenced this issue Jul 27, 2019
csp197 added a commit to csp197/numerox that referenced this issue Jul 27, 2019
csp197 added a commit to csp197/numerox that referenced this issue Jun 15, 2020
@csp197 csp197 mentioned this issue Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants