Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example_model_sunshine: shouldn't the NA filling be performed by era? #129

Open
luca-s opened this issue Jan 3, 2023 · 0 comments
Open

example_model_sunshine: shouldn't the NA filling be performed by era? #129

luca-s opened this issue Jan 3, 2023 · 0 comments

Comments

@luca-s
Copy link

luca-s commented Jan 3, 2023

I am referring to this line. I believe the median value of the features should be computed on a per-era basis to avoid introducing biases.
@luca-s luca-s changed the title example_model_sunshine: shouldn't the NA fillining be performed by era ? example_model_sunshine: shouldn't the NA filling be performed by era? Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luca-s