Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Inconsistent default SpatialPooler parameters #1104

Open
oxtopus opened this issue Sep 23, 2016 · 5 comments
Open

Inconsistent default SpatialPooler parameters #1104

oxtopus opened this issue Sep 23, 2016 · 5 comments

Comments

@oxtopus
Copy link
Contributor

oxtopus commented Sep 23, 2016

The default parameters for the c++ SpatialPooler (https://github.com/numenta/nupic.core/blob/master/src/nupic/algorithms/SpatialPooler.hpp#L232-L249) differ from the swig interface (https://github.com/numenta/nupic.core/blob/master/src/nupic/bindings/algorithms.i#L1020-L1037) file that provides bindings for python. Furthermore, both differ from the pure-python implementation in nupic (https://github.com/numenta/nupic/blob/master/src/nupic/research/spatial_pooler.py#L111-L129).

i.e. if you instantiate SP, you get different default parameters depending on which implementation you use.

Particularly, globalInhibition, seed, synPermActiveDec differ between implementations, and some names differ, e.g. minPctOverlapDutyCycle vs minPctOverlapDutyCycles.

Which is correct?

@rhyolight
Copy link
Member

@oxtopus I trust you will close this issue when you are satisfied with an answer and open up any new actions that should be taken in response to the answer as new issues.

@oxtopus
Copy link
Contributor Author

oxtopus commented Sep 27, 2016

@rhyolight
Copy link
Member

@oxtopus What is that, your theme song? 👏

@oxtopus
Copy link
Contributor Author

oxtopus commented Nov 16, 2016

Signal-boosting to @numenta/nupic-committers in case anyone has any opinions. If not, I'll roll some dice and make them consistent in a followup PR.

@oxtopus
Copy link
Contributor Author

oxtopus commented Nov 16, 2016

@rhyolight here's the mixtape version: https://www.youtube.com/watch?v=4YKlDpX3swI

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants