Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to migrate library from Offset Based Pagination to Cursor Based Pagination #276

Open
gkatechis opened this issue May 22, 2023 · 6 comments
Labels
API Support New API support

Comments

@gkatechis
Copy link

Zendesk currently offers both offset-based pagination (OBP) and cursor-based pagination (CBP) for most API endpoints. CBP offers many performance advantages over OBP and will be the primary method of pagination offered at Zendesk in the near future. In an effort to provide a better, faster experience for our customers we are taking steps to encourage a transition to CBP – starting with the introduction of tighter limits on high-offset OBP requests.

What is changing?
Beginning on August 15, 2023, OBP requests over the first 100 pages (10,000 records) will result in an error message: “400 Bad Request.” In order to request data sets larger than 10,000 records, customers will need to transition to CBP.
OBP requests for fewer than 100 pages will not be affected, nor will requests made using the CBP model.

Why is Zendesk making this change?
We are making this change in line with our previous announcement recommending adoption of CBP and to encourage customers to make the switch as soon as possible. Not only is cursor-based pagination faster and more efficient for our customers, it also puts less strain on Zendesk infrastructure and increases stability and reliability. As a first step, we are limiting offset-based pagination capabilities at a relatively high level, so that the transition can take place with minimal disruption to current API usage.

What do I need to do?
Zendesk strongly encourages library maintainers to make the transition to cursor-based pagination before August 15, 2023. If you decide to not transition your library please add documentation in regards to the 100 page OBP limit to your library. If we have not heard from you in regards to this change prior to August 15, 2023. We will be removing our reference to your library from our documentation and will consider it abandoned / unmaintained.

@gkatechis
Copy link
Author

Hi again from Zendesk! I wanted to follow up on this because it looks like the changes haven't been pushed yet. As a reminder, on August 15, 2023, OBP requests over the first 100 pages (10,000 records) will result in an error message: “400 Bad Request.” In order to request data sets larger than 10,000 records, you will need to transition to CBP.

@gkatechis
Copy link
Author

I wanted to drop another update to make sure that the above has been seen. Starting last week, you may have begun seeing the results of the change, so make sure to address this in the near future!

@cryptomail
Copy link

@nukosuke HI THERE!!!! We will be embarking on adding CBP soon and contributing to the efforts here.
I wanted to just ping you here and say hello, personally, and that you can expect us to submit a PR soon.
With that...
🎩 HELLO!!! <3 thank you for making this library!

@nukosuke
Copy link
Owner

nukosuke commented Sep 16, 2023

Sorry for the late reply 🙇‍♂️
Unfortunately, I don't have enough time to tackle this issue now.

@gkatechis, @cryptomail

We will be embarking on adding CBP soon and contributing to the efforts here.
I wanted to just ping you here and say hello, personally, and that you can expect us to submit a PR soon.

I really appriciate your suggestion. Yes, I'm willing to take pull request from anyone who are interested in contributing to this library.

Best regards.

@nukosuke nukosuke added the API Support New API support label Sep 16, 2023
@cryptomail
Copy link

@nukosuke Thank you so much! I look forward to getting my team involved directly in this effort and give the best solution possible.

@JinHuangAtZen
Copy link
Contributor

Hi @nukosuke , I've created a new PR as the initial step to introduce Cursor Based Pagination to this fantastic library. The idea is to introduce an Iterator to return the results using Cursor Based Pagination by default.
Please review when you get a chance.

Thanks and Regards
Jin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Support New API support
Projects
None yet
Development

No branches or pull requests

4 participants