Responsify header #328
Merged
Responsify header #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be merged to integration/webapp as well right? Thanks. |
|
@sethuraj yes, I was waiting for the #320 to be merged before I undraft this, cos I built it on top of those changes. ready for review /cc @aviskarkc10 |
|
LGTM 👍 |
aviskarkc10
approved these changes
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On smallest screens the nav menu covered almost the whole screen but not all of it, which didn't look good.
While working on this noticed that the search results don't look good either, as they were shown in a small misaligned popup.
Description
Made the menu full-width on smallest screens.
Fixed search results to match the input width.
Fixed hamburger icon alignment.
Improved close button styles, aligning it with the now covered hamburger icon, so that the user doesn't have to shift their finger when expanding and collapsing.
Fixes #305
Implementation
buttonwere moved to a specific class for file upload, so that button elements can be used more freely.Type of change
New feature
Screenshots/Links
Nav menu - desktop:
Nav menu - phone:
Search bar and hamburger icon - before:
Search Bar and hamburger icon - after: