Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feed figure included image styles missing #334

Open
ophian opened this issue Jan 29, 2021 · 3 comments
Open

feed figure included image styles missing #334

ophian opened this issue Jan 29, 2021 · 3 comments

Comments

@ophian
Copy link

ophian commented Jan 29, 2021

non-public. URL Sorry!
version: 3.2

My feeds have possible html "figure/figcaption" tags around some images for comments.
It does need the following addition to the reader.css;

.item figure {
    display: inline;
}

and change the max-width of:

.item img {
  max-width: 50%;
  height: auto;
  vertical-align: middle;
}

to

.item img {
  max-width: 100%;
  height: auto;
  vertical-align: middle;
}

which works well with all others too.
Thanks!

@ophian ophian changed the title feed figure included image styles mssing feed figure included image styles missing Jan 29, 2021
@evilpie
Copy link
Collaborator

evilpie commented Feb 6, 2021

Thanks for the suggestion. I think this might not work well for us however. The idea was, I think, for text to flow around images located on the left side. A few feeds have small thumbnail sized images that shouldn't take the full width.

@ophian
Copy link
Author

ophian commented Feb 6, 2021

No, I don't think so.
It (the .item img { max-width: 100% ...) would just expand to the full image width, surrounded and influenced by its parent container(s); In my case the figure element. The feed viewer should not try to be more clever than the blogger and size images to 50% of their value.
So, if you think for smaller left sided images (which was mine too) you should as well do for images that are bigger (which was also true for mine).

@evilpie
Copy link
Collaborator

evilpie commented Feb 6, 2021

I guess you are right. I am by no means an CSS expert. Looking https://deathclawdesu.tumblr.com/rss the text doesn't flow around the image and the image is squashed. Removing the max-width makes it look better. Please open a PR, maybe @nt1m can take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants