New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling box #56
Styling box #56
Conversation
public/class-drawattention.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the public-facing code for the front end of the website. The admin code is in admin/class-drawattention-admin.php. You'll see the other 'admin_enqueue_scripts' hooks in that file. We would also want to include the plugin slug prepended to the name of the style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than being a standalone CSS file, this should be in admin/assets/css/admin.css with the other CSS that applies to the admin UI. But, as I was the only frontend dev on this plugin for nearly 10 years, I have a weird sass compiler in use that you don't have access to. If you want to add your code to admin/assets/sass/admin.scss, I can compile it before this PR merges in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NatalieMac I will add my code to admin/assets/sass/admin.scss.
Just to make sure, should I remove the add_action hook and the function used to enqueue a stylesheet I added before ?
@NatalieMac I added the CSS code to admin.css file as you requested instead of having a standalone CSS file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeinshhadi I went ahead and re-compiled the Sass so this is all looking good now.
Asana Task : https://app.asana.com/0/1202993069895285/1206835804889510/f
Loom video : https://www.loom.com/share/96da9a72380145f3a00148838707666a?sid=25f5edfa-73a0-468b-bd95-a1a99f28762f
Description : Fixed styling of boxes in more info.