Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling box #56

Merged
merged 10 commits into from Apr 11, 2024
Merged

Styling box #56

merged 10 commits into from Apr 11, 2024

Conversation

zeinshhadi
Copy link
Contributor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the public-facing code for the front end of the website. The admin code is in admin/class-drawattention-admin.php. You'll see the other 'admin_enqueue_scripts' hooks in that file. We would also want to include the plugin slug prepended to the name of the style.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than being a standalone CSS file, this should be in admin/assets/css/admin.css with the other CSS that applies to the admin UI. But, as I was the only frontend dev on this plugin for nearly 10 years, I have a weird sass compiler in use that you don't have access to. If you want to add your code to admin/assets/sass/admin.scss, I can compile it before this PR merges in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NatalieMac I will add my code to admin/assets/sass/admin.scss.
Just to make sure, should I remove the add_action hook and the function used to enqueue a stylesheet I added before ?

@zeinshhadi
Copy link
Contributor Author

@NatalieMac I added the CSS code to admin.css file as you requested instead of having a standalone CSS file.
Loom Video

Copy link
Contributor

@NatalieMac NatalieMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeinshhadi I went ahead and re-compiled the Sass so this is all looking good now.

@tylerdigital tylerdigital merged commit b693bcd into master Apr 11, 2024
5 of 6 checks passed
@tylerdigital tylerdigital deleted the styling-box branch April 11, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants