Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: publish ARM images #1306

Closed
duanhongyi opened this issue Nov 26, 2020 · 8 comments
Closed

docker: publish ARM images #1306

duanhongyi opened this issue Nov 26, 2020 · 8 comments

Comments

@duanhongyi
Copy link

duanhongyi commented Nov 26, 2020

Now arm is used more and more widely. At present, many projects have docker images of arm, such as Nats. I hope that maintainers can add arm related images in docker hub.

@mreiferson mreiferson changed the title docker: add arm related compilation in docker hub docker: add ARM related compilation in docker hub Jan 1, 2021
@mreiferson mreiferson changed the title docker: add ARM related compilation in docker hub docker: publish ARM images Jan 1, 2021
@danbf
Copy link
Contributor

danbf commented Jul 20, 2021

3vb9g9

this may be as simple as changing over to buildx in the image build chain ala'

docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v7

https://www.docker.com/blog/multi-arch-images/

i might be able to write a patch for this if someone points to the relevant section

@danbf
Copy link
Contributor

danbf commented Jul 20, 2021

is it changing https://github.com/nsqio/nsq/blob/master/dist.sh#L45 to this gonna do it?

docker buildx build -t nsqio/nsq:v$version . --platform linux/amd64,linux/arm64,linux/arm/v7 --push

@danbf
Copy link
Contributor

danbf commented Jul 21, 2021

@mreiferson ^^

@danbf
Copy link
Contributor

danbf commented Jul 22, 2021

actually since buildx needs some setup, i do this on my end for multi-arch's:

ensure i cleared out the buildx builder in case it got interrupted before

docker buildx rm <builder-name>

then:

docker buildx create --name <builder-name>
docker buildx use <builder-name>
docker buildx build --tag <remote_tag> . --platform linux/amd64,linux/arm64,linux/arm/v7 --push

then clear out the buildx builder so it's ready for the next time i run it

docker buildx rm <builder-name>

@danbf
Copy link
Contributor

danbf commented Jul 23, 2021

i have it running in sso like this buzzfeed/sso#319 so i'll take a crack at this

@mreiferson
Copy link
Member

looking forward to it @danbf

@danbf
Copy link
Contributor

danbf commented Aug 3, 2021

@mreiferson got the PR in #1355 for 👀

@mreiferson
Copy link
Member

see #1355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants