Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional fields to "add link" page #295

Open
hazelshapiro opened this issue May 1, 2024 · 2 comments
Open

Add additional fields to "add link" page #295

hazelshapiro opened this issue May 1, 2024 · 2 comments
Labels
enhancement New feature or request impact/datamodel Impacts structure of data in the database

Comments

@hazelshapiro
Copy link
Collaborator

hazelshapiro commented May 1, 2024

Should include three text description boxes (and new fields on the Link model):

  • Performance rationale: 8192 char limit
  • Criticality rationale: 8192 char limit
  • Gaps: 8192 char limit

Also:

  • Variable/attribute: TBD: what is this?
  • Rated by: The person who rated the link. TBD: How to determine this value? The first person to apply the rating, or the most recent person to update the rating? Allow the value to be selected from a dropdown? Determine it automatically, but allow admins to override (I would consider this a separate feature; for the purpose of this ticket let's pick only one thing)?

See glossary for more info

@hazelshapiro hazelshapiro added this to the 2 - User Feedback milestone May 1, 2024
@hazelshapiro hazelshapiro changed the title Add rating criteria to "add link" page Add additional fields to "add link" page May 1, 2024
@mfisher87 mfisher87 added enhancement New feature or request impact/datamodel Impacts structure of data in the database labels May 10, 2024
@Sherwin-14
Copy link
Contributor

@mfisher87 Is this still relevant? Do you have any specific opinions regarding this?

@mfisher87
Copy link
Member

mfisher87 commented May 12, 2024

Hey @Sherwin-14 :) This is still relevant. Looks like we currently only have performance and criticality rating, but we need to add rationale and the others:

performance_rating = Column(
Integer,
CheckConstraint(
'performance_rating>0 and performance_rating<101',
name='p1-100',
),
nullable=False,
)
criticality_rating = Column(
Integer,
CheckConstraint(
'criticality_rating>0 and criticality_rating<11',
name='c1-10',
),
nullable=False,
)

I am updating the issue description to include what I know. I'm thinking we could create a constant (if there isn't already one) so we can update all the large text fields at once, e.g. DB_TEXT_SIZE_LARGE = 8196, and similar constants for the other common string lengths we use. That way it will be easier to change them if we get them wrong :)

@hazelshapiro I'm adding some "TBD" markers to the issue description. Can you fill those in and also verify the character limits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request impact/datamodel Impacts structure of data in the database
Projects
Status: No status
Development

No branches or pull requests

3 participants