Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legend to visual display #189

Open
1 task done
hazelshapiro opened this issue Dec 1, 2023 · 5 comments
Open
1 task done

Add legend to visual display #189

hazelshapiro opened this issue Dec 1, 2023 · 5 comments
Labels
enhancement New feature or request impact/ui Impacts the the user interface question Further information is requested

Comments

@hazelshapiro
Copy link
Collaborator

hazelshapiro commented Dec 1, 2023

Indicate with a color key, similar to below, which colors correspond to which performance rating values.

image

  • Should we use this colormap? No, Viridis
@mfisher87
Copy link
Member

@hazelshapiro can you please clarify? A scale bar is something I imagine we'd see on a map, but not a sankey diagram, as the diagram has no real-world size.

@mfisher87 mfisher87 added question Further information is requested enhancement New feature or request impact/ui Impacts the the user interface labels Jan 6, 2024
@hazelshapiro
Copy link
Collaborator Author

This would be a key to say what colors correspond to what performance score

@mfisher87 mfisher87 changed the title Add scale bar to visual display Add legend to visual display Jan 8, 2024
@mfisher87 mfisher87 removed the question Further information is requested label Jan 8, 2024
@mfisher87
Copy link
Member

Got it. On the legacy site, we have the option to color by node type or value:

image

image

Will our first implementation be to color by value, and later add other coloring options?

What do you think about a different colormap for this? The current one is not accessible to those with color vision deficiency (CVD), and it would be easier to start out with an accessible colormap than to come back to it later.

@mfisher87 mfisher87 added the question Further information is requested label Jan 8, 2024
@mfisher87
Copy link
Member

We met and decided to start with replacing this colormap with Viridis to see how our expert committee likes it. Going forward, we may support selecting various colormaps.

@mfisher87
Copy link
Member

mfisher87 commented Mar 21, 2024

@hazelshapiro with #282 do we still need this ticket? Or do we want the legend to be in this specific style? (in which case, let's re-title the ticket)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request impact/ui Impacts the the user interface question Further information is requested
Projects
Status: Feedback required
Development

No branches or pull requests

2 participants