Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect http => https where possible ; add HSTS headers #35

Open
patrickod opened this issue Dec 21, 2016 · 0 comments
Open

Redirect http => https where possible ; add HSTS headers #35

patrickod opened this issue Dec 21, 2016 · 0 comments

Comments

@patrickod
Copy link
Collaborator

In the following set of steps:

  1. navigate to root URL over plaintext HTTP
  2. complete oauth flow
  3. are redirected back to https:// callback URL

you'll be greeted with a 404 as the request handler is unable to read the auth_url out of the session cookie since in step 1 it was set on a cookie with the secure parameter meaning that it's dropped by the browser.

We should pre-empt this and redirect all http requests to https first, and also set HSTS headers to prevent subsequent visits from hitting this redirect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant