Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the 04-RSVP experiment, I found a problem #52

Open
immort-magic opened this issue Feb 29, 2024 · 3 comments
Open

In the 04-RSVP experiment, I found a problem #52

immort-magic opened this issue Feb 29, 2024 · 3 comments

Comments

@immort-magic
Copy link

when a subscription request of the same priority does not meet the bandwidth allocation, the first subscription request is deleted, it should not be deleted.
In line 417 of rsvp_controller.py, it should be commented, I think it is, you can think about it again.

@edgar-costa
Copy link
Contributor

Hi @immort-magic

You mean this line: https://github.com/nsg-ethz/p4-learning/blob/master/exercises/04-RSVP/thrift/solution/rsvp_controller.py#L417

I think it is correct, this line only removes the subscription if its an update meaning its changing an already existing subscription, it deletes to just update it.

@immort-magic
Copy link
Author

I found it, in the case of a failed booking, the previous booking was simply deleted, you can try it.
Snipaste_2024-03-04_16-52-40

@immort-magic
Copy link
Author

i think previous reservation should not be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants