New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nx release in "projectRelationship": "independent" mode is not tagging and releasing projects that depend on projects that are getting published #22268
Comments
This is also something I just ran into, as an example jscutlery has a --trackDeps flag which enables one to opt in to this behavior. Is there some setting somewhere that we can opt in for nx release that we are missing? |
Propagate release for all dependant packages that need updating when projectRelationship is "independent" . Fixes nrwl#22268
Hey, we're facing the same issue in our repository where the package @jscutlery/swc-angular-preset has implicit dependency + peer dependency on @jscutlery/swc-plugin-angular, yet when we release the swc-angular-preset project it doesn't bump the swc-plugin-angular including the peer dependency update. |
Hey @edbzn and @brugi82, Nx Release doesn't update the version of |
The PR to address this is ready for review here: #22836 |
I have the following scenario: With this fix, will it be required for lib-A and lib-B to have its own package.json, even if I don't version/release them? The only versioning/release is for app-A. The |
Current Behavior
nx release
in"projectRelationship": "independent"
mode is only tagging and releasing projects with changes. If there are projects that depend on these projects, they are not getting tagged and released.For example, if we have 2 libraries,
is-even
andis-odd
.is-odd
has a dependency on packageis-even
that is correctly identified bydependency-checks
eslint
rule, and stated in it'spackage.json
file. When changes are committed to packageis-even
andnx release
is triggered, only that package is tagged for release.is-odd
'spackage.json
is getting updated, but the package is not getting released.Our
release
configuration fromnx.json
:Expected Behavior
We are expecting that with the changes made to the "root" package,
release
bubbles up to all packages that depend on that package too. In this concrete example, we are expecting that with the changes made tois-even
package,nx release
not only triggers and tagsis-even
package, butis-odd
package too, as that one directly depends onis-even
.GitHub Repo
https://github.com/brugi82/nx-independent-monorepo
Steps to Reproduce
is-odd
depends on packageis-even
.is-even
has one committed change that is not released.nx release --skip-publish --dry-run --verbose
is-even
is getting tagged & released.Nx Report
Failure Logs
No response
Package Manager Version
yarn 4.1.0
Operating System
Additional Information
I am willing to submit a PR that solves this problem.
The text was updated successfully, but these errors were encountered: