Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trigonometric augmentation user friendly #10

Open
nrontsis opened this issue Jul 16, 2018 · 2 comments
Open

Make trigonometric augmentation user friendly #10

nrontsis opened this issue Jul 16, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@nrontsis
Copy link
Owner

Matlab's implementation augments the variables that represents angles to two new states that are simply their cos and sin.

This is important for the performance of the algorithm and is possible to be done in the current implementation by simply passing an augmented dataset to the PILCO object.

Investigate how to do this in a more user friendly way.

@nrontsis nrontsis added the enhancement New feature or request label Jul 16, 2018
@RicardoDominguez
Copy link

Hey Nikitas,

I can address this issue if you haven't started working on it.

I was thinking about passing to the PILCO object a set of indices similar to the ones used in the MATLAB PILCO version (angi, dyni, dyno...)

@nrontsis
Copy link
Owner Author

Sure, PRs are welcome!

While coding, keep in mind that the purpose of this package is to provide researchers/experts of the area of gaussian process dynamical systems with a basic & clean implementation for PILCO. So we usually opt for code readability/conciseness instead of user friendliness [that is, when we can't have both :) ].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants