New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor docker_base to use inversion of control #421
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against eccb933 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today I learned inversion of control. Thanks for that. This looks good to me. I still would like to see these PRs getting entries in the changelog, so we can track when these things go in. Thanks for doing this. I'm really interested in seeing where this goes.
Sure; done! |
# Conflicts: # buildstockbatch/cloud/docker_base.py # docs/changelog/changelog_dev.rst
Pull Request Description
Use inversion of control in docker_base so that it can more strongly and easily ensure consistency between various implementations (GCP implementation to come).
This also includes teasing apart the several batch prep steps (weather, assets, and jobs) into their own methods so they can each be more easily understood, shared, and maintained.
Checklist
Not all may apply
test_docker_base.py
passesminimum_coverage
in.github/workflows/coverage.yml
as necessary.Update validation for project config yaml file changesUpdate existing documentationRun a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle