Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Service Account #414

Merged
merged 9 commits into from Nov 21, 2023
Merged

AWS Service Account #414

merged 9 commits into from Nov 21, 2023

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Nov 10, 2023

Fixes #412
Merge after #405

Pull Request Description

Switching to a shared service account for Kestrel and Eagle.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Kestrel to make sure it all works if you made changes that will affect Kestrel
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket self-assigned this Nov 10, 2023
Copy link

github-actions bot commented Nov 10, 2023

File Coverage
All files 86%
base.py 90%
exc.py 57%
hpc.py 78%
local.py 70%
postprocessing.py 84%
utils.py 91%
cloud/docker_base.py 93%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/shared_testing_stuff.py 85%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 495dfec

@nmerket nmerket marked this pull request as ready for review November 10, 2023 19:11
Base automatically changed from kestrel to develop November 21, 2023 20:26
@nmerket nmerket merged commit 941c606 into develop Nov 21, 2023
6 checks passed
@nmerket nmerket deleted the aws_service_account branch November 21, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS service account for Eagle and Kestrel
1 participant