Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing /tmp/scratch files at end of array job #406

Merged
merged 7 commits into from Nov 7, 2023

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Oct 31, 2023

Fixes #404.

Pull Request Description

At the request of the HPC team, we're cleaning up /tmp/scratch at the end of the job because their script is timing out and causing the nodes to fail and be pulled out of the pool.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket self-assigned this Nov 1, 2023
@nmerket nmerket requested a review from whiphi92 November 1, 2023 16:55
Copy link

github-actions bot commented Nov 3, 2023

File Coverage
All files 86%
base.py 90%
eagle.py 77%
exc.py 57%
local.py 70%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against e639163

Copy link

@whiphi92 whiphi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little out of my depth, but this looks good. Approved.

@nmerket nmerket merged commit 45082ec into develop Nov 7, 2023
6 checks passed
@nmerket nmerket deleted the eagle_tmp_scratch_cleanup branch November 7, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/tmp/scratch timeout
2 participants