Allows non-integer minutes_per_sim #396

nmerket · 2023-10-10T20:20:27Z

Fixes #377.

I tested it on Eagle and it has the intended effect.

github-actions · 2023-10-10T21:33:22Z

File	Coverage
All files	`84%`	✅
base.py	`89%`	✅
eagle.py	`79%`	✅
exc.py	`57%`	✅
local.py	`50%`	✅
postprocessing.py	`84%`	✅
utils.py	`96%`	✅
sampler/base.py	`79%`	✅
sampler/downselect.py	`33%`	✅
sampler/precomputed.py	`93%`	✅
sampler/residential_quota.py	`61%`	✅
test/test_docker.py	`33%`	✅
test/test_validation.py	`97%`	✅
workflow_generator/base.py	`90%`	✅
workflow_generator/commercial.py	`53%`	✅
workflow_generator/residential_hpxml.py	`84%`	✅

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 7cee175

afontani · 2023-10-10T21:58:24Z

buildstockbatch/schemas/v0.3.yaml

@@ -39,7 +39,7 @@ aws-emr-spec:

 hpc-spec:
  account: str(required=True)
-  minutes_per_sim: int(max=480, required=False)
+  minutes_per_sim: num(min=0.05, max=480, required=True)


Looks like we will need another 10x reduction before this becomes an issue. Probably safe.

afontani · 2023-10-10T21:59:21Z

buildstockbatch/test/test_eagle.py

@@ -195,6 +194,33 @@ def test_qos_high_job_submit(mock_subprocess, basic_residential_project_file, mo
        assert '--qos=high' in mock_subprocess.run.call_args[0][0]


+def test_queue_jobs_minutes_per_sim(mocker, basic_residential_project_file, monkeypatch):


I am glad to see this test.

nmerket added 2 commits October 10, 2023 14:16

Allows non-integer minutes_per_sim

29c5f58

adding and fixing tests

e1f03be

nmerket added this to the v2023.10.0 milestone Oct 10, 2023

adding fake conda prefix for testing

7cee175

nmerket requested a review from afontani October 10, 2023 21:43

nmerket self-assigned this Oct 10, 2023

afontani approved these changes Oct 10, 2023

View reviewed changes

nmerket merged commit fdbeb62 into develop Oct 10, 2023
6 checks passed

nmerket deleted the allow_fast_sims branch October 10, 2023 23:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allows non-integer minutes_per_sim #396

Allows non-integer minutes_per_sim #396

nmerket commented Oct 10, 2023

github-actions bot commented Oct 10, 2023

afontani Oct 10, 2023

afontani Oct 10, 2023

		@@ -195,6 +194,33 @@ def test_qos_high_job_submit(mock_subprocess, basic_residential_project_file, mo
		assert '--qos=high' in mock_subprocess.run.call_args[0][0]


		def test_queue_jobs_minutes_per_sim(mocker, basic_residential_project_file, monkeypatch):

Allows non-integer minutes_per_sim #396

Allows non-integer minutes_per_sim #396

Conversation

nmerket commented Oct 10, 2023

github-actions bot commented Oct 10, 2023

afontani Oct 10, 2023

Choose a reason for hiding this comment

afontani Oct 10, 2023

Choose a reason for hiding this comment