Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken CI tests #387

Merged
merged 2 commits into from Aug 16, 2023
Merged

Remove broken CI tests #387

merged 2 commits into from Aug 16, 2023

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Aug 14, 2023

Fixes #385

Pull Request Description

This is punting. I'm just removing the tests that were problematic. The new pandas version revealed that there are problems with the old test data that we keep in this repo, which was more directly the source of the test failures. Now that we have full integration tests set up and can run ResStock and soon ComStock in CI, we can test postprocessing in a more holistic way. I was trying to just edit the parquet files in the testing directory to match what was expected, but I would've had to do some weird things to make it work and at that point the tests were kind of meaningless. I'm going to add some more issues of tests that we should consider adding for a more complete and wholistic test coverage.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket requested a review from rajeee August 14, 2023 23:12
@github-actions
Copy link

File Coverage
All files 84%
base.py 89%
eagle.py 75%
exc.py 57%
local.py 50%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 83%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against e677187

@nmerket nmerket merged commit 1277a5c into develop Aug 16, 2023
@nmerket nmerket deleted the ci-fix branch August 16, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI issues with newer version of pandas and existing parquet files in repo
2 participants