Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResStock-HPXML: resilience and bill arguments #383

Merged
merged 7 commits into from Oct 10, 2023
Merged

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Aug 1, 2023

Closes #381.

Support the following ReportSimulationOutput changes:

  • Arguments include_annual_resilience and include_timeseries_resilience are now available. We will fix (i.e., user has no option to override) requesting annual resilience outputs. Requesting timeseries resilience outputs is optional.

Support the following ReportUtilityBills changes:

  • Arguments include_annual_bills, include_monthly_bills, and monthly_timestamp_convention are now available. We will fix (i.e., user has no option to override) requesting annual utility bill outputs and not requesting monthly utility bill outputs.

Checklist

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@joseph-robertson joseph-robertson self-assigned this Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 21, 2023

File Coverage
All files 84%
base.py 89%
eagle.py 79%
exc.py 57%
local.py 50%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 84%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against c5bb12d

@nmerket nmerket added this to the v2023.10.0 milestone Oct 3, 2023
@joseph-robertson joseph-robertson marked this pull request as ready for review October 3, 2023 19:55
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I dropped the checklist in and you got it all in there. If you could just add a line to the changelog I think this is good to merge.

@nmerket nmerket merged commit 49c34aa into develop Oct 10, 2023
6 checks passed
@nmerket nmerket deleted the res-wfg-args branch October 10, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Residential HPXML workflow generator updates
2 participants