Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references section to yaml schema #366

Merged
merged 5 commits into from May 4, 2023
Merged

Add references section to yaml schema #366

merged 5 commits into from May 4, 2023

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented May 4, 2023

Add a throwaway section in the yaml schema called references where yaml anchor references can be defined to be used in other places. Without this dedicated section, there is no way to define all the references at single location and one would have to define their anchor at the first point of use.

@nmerket
Copy link
Member

nmerket commented May 4, 2023

Can you add a changelog entry and maybe a test that shows this working?

@github-actions
Copy link

github-actions bot commented May 4, 2023

File Coverage
All files 84%
base.py 89%
eagle.py 74%
exc.py 57%
local.py 50%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 69%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against e50d9be

@rajeee rajeee requested a review from nmerket May 4, 2023 19:55
@nmerket nmerket merged commit 70036d7 into develop May 4, 2023
6 checks passed
@nmerket nmerket deleted the references branch May 4, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants