Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResStock-HPXML: include_annual arguments #363

Merged
merged 10 commits into from May 24, 2023
Merged

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Apr 3, 2023

Support the following ReportSimulationOutput changes:

  • A bunch of include_annual_foo are now available. We will fix (i.e., user has no option to override) requesting all annual outputs, except for system use consumptions which will always not be requested.
  • Also fixes new include_timeseries_system_use_consumptions argument to always false.

@joseph-robertson joseph-robertson self-assigned this Apr 3, 2023
@joseph-robertson joseph-robertson changed the title Test new include_annual arguments ResStock-HPXML: include_annual arguments Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

File Coverage
All files 83%
base.py 88%
eagle.py 75%
exc.py 57%
local.py 50%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 75%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 5e653dc

@joseph-robertson joseph-robertson marked this pull request as ready for review April 4, 2023 21:08
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pulling up the checklist from the pull request template...

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts) Is it worth adding a simple test around this feature in the test_workflow_generator.py?
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@joseph-robertson
Copy link
Contributor Author

joseph-robertson commented Apr 4, 2023

New test_workflow_generator.py checks are commented out because the test checks against resstock develop... but the new arguments aren't on develop yet...

Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. At what point do we merge this? Before or after the corresponding resstock change?

@joseph-robertson
Copy link
Contributor Author

I think we merge here, then release buildstockbatch. Then I can go into the resstock PR and point to the tagged buildstockbatch release before merging it into develop. Does that sound right?

@nmerket nmerket added this to the v2023.04.0 milestone Apr 21, 2023
@rajeee rajeee requested a review from nmerket May 3, 2023 19:09
@nmerket nmerket merged commit 54ae52f into develop May 24, 2023
6 checks passed
@nmerket nmerket deleted the disable-annual-outputs branch May 24, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants