New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResStock-HPXML: include_annual arguments #363
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 5e653dc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pulling up the checklist from the pull request template...
- Code changes (must work)
- Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts) Is it worth adding a simple test around this feature in the test_workflow_generator.py?
- Coverage has increased or at least not decreased. Update
minimum_coverage
in.github/workflows/ci.yml
as necessary. - All other unit and integration tests passing
- Update validation for project config yaml file changes
- Update existing documentation
- Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
- Add to the changelog_dev.rst file and propose migration text in the pull request
New |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good. At what point do we merge this? Before or after the corresponding resstock change?
I think we merge here, then release buildstockbatch. Then I can go into the resstock PR and point to the tagged buildstockbatch release before merging it into develop. Does that sound right? |
Support the following ReportSimulationOutput changes:
include_annual_foo
are now available. We will fix (i.e., user has no option to override) requesting all annual outputs, except for system use consumptions which will always not be requested.include_timeseries_system_use_consumptions
argument to always false.