Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce strict naming for database and table names #362

Merged
merged 6 commits into from Apr 3, 2023
Merged

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Apr 1, 2023

There is a strict naming requirement for Athena database and table names. Although glue crawler accepts names outside of this convention, it can lead to problems down the road. This PR enforces a strict naming convention for database name and table name (which comes from the output directory name).

Migration:
Change the database_name and output folder name to start with a letter and only include lowercase letters, numbers and underscore character.

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

File Coverage
All files 84%
base.py 89%
eagle.py 74%
exc.py 57%
local.py 50%
postprocessing.py 85%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 69%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 610dca3

@rajeee rajeee requested a review from nmerket April 3, 2023 15:50
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts) Probably don't need that
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@rajeee rajeee requested a review from nmerket April 3, 2023 17:27
@nmerket nmerket merged commit f398d85 into develop Apr 3, 2023
6 checks passed
@nmerket nmerket deleted the strict_names branch April 3, 2023 17:29
@nmerket nmerket added this to the v2023.04.0 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants