Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force schedule columns to float #355

Merged
merged 2 commits into from Mar 3, 2023
Merged

Force schedule columns to float #355

merged 2 commits into from Mar 3, 2023

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Mar 2, 2023

Addresses #352

Sometimes a building's particular schedule column can have integer only values which results in pandas assigning integer datatype to that column. But this causes problem when generating the metadata during postprocessing since other schedule file can have float datatypes. This PR fixes the issue by always interpreting the schedule values as float during read.

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

File Coverage
All files 84%
base.py 89%
eagle.py 74%
exc.py 57%
local.py 50%
postprocessing.py 85%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 69%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against cdfa113

Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put in a changelog entry for this?

@nmerket nmerket merged commit 1892a36 into develop Mar 3, 2023
@nmerket nmerket deleted the fix_schedules branch March 3, 2023 21:18
@nmerket nmerket added this to the v2023.04.0 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants