Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResStock-HPXML: simple bill calcs (enhancement) #351

Merged
merged 10 commits into from Jun 12, 2023
Merged

Conversation

joseph-robertson
Copy link
Contributor

See NREL/resstock#1012 for context.

@joseph-robertson joseph-robertson self-assigned this Feb 22, 2023
@github-actions
Copy link

github-actions bot commented Feb 22, 2023

File Coverage
All files 84%
base.py 89%
eagle.py 75%
exc.py 57%
local.py 50%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 83%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against e3c7b1c

@joseph-robertson joseph-robertson marked this pull request as ready for review February 23, 2023 18:28
@joseph-robertson joseph-robertson changed the title Simple bill calcs (enhancement) ResStock-HPXML: simple bill calcs (enhancement) May 15, 2023
@joseph-robertson
Copy link
Contributor Author

Just pulling up the checklist from the pull request template...

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts) Is it worth adding a simple test around this feature in the test_workflow_generator.py?
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket added the DO NOT MERGE PR is open but please don't merge! label May 23, 2023
@nmerket nmerket merged commit c0251d9 into develop Jun 12, 2023
6 checks passed
@nmerket nmerket deleted the simple-bill-calcs2 branch June 12, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PR is open but please don't merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants