Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting results by building_id #332

Merged
merged 2 commits into from Dec 1, 2022
Merged

Sorting results by building_id #332

merged 2 commits into from Dec 1, 2022

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Dec 1, 2022

Fixes #331.

Pull Request Description

Sorts results by building_id in the results csvs and parquets.

I didn't add a specific test for this one because it only gets unsorted on Eagle, so I couldn't duplicate the problem locally. I did run a test run on Eagle to confirm that it works now, though.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

File Coverage
All files 86%
base.py 88%
eagle.py 74%
exc.py 57%
localdocker.py 63%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 83%
test/test_validation.py 96%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 70%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against d8db298

Copy link
Collaborator

@afontani afontani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like df.sort_index(inplace=True) was just out of place. Looks good.

@nmerket nmerket merged commit 54dee57 into develop Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order results.csvs by building_id
2 participants