Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask Worker Bugfix #324

Merged
merged 3 commits into from Oct 31, 2022
Merged

Dask Worker Bugfix #324

merged 3 commits into from Oct 31, 2022

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Oct 31, 2022

Pull Request Description

In some recent changes to the dask worker cli, an option we were using, --nprocs, was replaced. The change made it so the workers never started on Eagle for postprocessing. This switches things over to the new style and requires the new dask version.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket added bug Something isn't working eagle labels Oct 31, 2022
@nmerket nmerket requested a review from whiphi92 October 31, 2022 21:04
@nmerket nmerket self-assigned this Oct 31, 2022
@github-actions
Copy link

github-actions bot commented Oct 31, 2022

File Coverage
All files 81%
base.py 81%
eagle.py 74%
exc.py 57%
localdocker.py 44%
postprocessing.py 84%
utils.py 96%
sampler/base.py 69%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 50%
test/test_validation.py 96%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 36%

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against 5f90201

@nmerket nmerket merged commit d88a628 into develop Oct 31, 2022
@lixiliu lixiliu mentioned this pull request Jan 9, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working eagle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants