Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for common apply logic error. #295

Merged
merged 8 commits into from Jun 13, 2022
Merged

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Jun 8, 2022

Pull Request Description

Add validator for apply logic. Currently, validates that 'and' and 'not' block doesn't contain the same option more than once (which typically means it should have been 'or' block).

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

File Coverage
All files 79%
base.py 81%
eagle.py 72%
exc.py 57%
localdocker.py 27%
postprocessing.py 84%
utils.py 96%
sampler/base.py 69%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 50%
test/test_validation.py 96%
workflow_generator/base.py 90%
workflow_generator/commercial.py 24%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 59%

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against 8624cbc

:pullreq: 295
:tickets:

Add basic logic validation that checks for incorrect use of 'and' and 'not' block.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention dropping support for python 3.7?

Copy link
Contributor Author

@rajeee rajeee Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that.

@nmerket nmerket merged commit 73216c8 into develop Jun 13, 2022
@nmerket nmerket deleted the logic_validator branch June 13, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants