Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mounting a temp dir into the singularity container #291

Merged
merged 6 commits into from Oct 3, 2022
Merged

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented May 18, 2022

Fixes NREL/OpenStudio-HPXML#1070

Pull Request Description

The simulation is trying to write files to /tmp inside the container. Here we're mounting a temporary directory from /tmp/scratch into it instead so there's enough room. See NREL/OpenStudio-HPXML#1071 (comment)

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@mnblonsky @shorowit

@joseph-robertson
Copy link
Contributor

This one is probably outside my wheelhouse. I probably wouldn't be a very effective reviewer for this PR.

@mnblonsky
Copy link

@nmerket I got my simulation working on HPC using the eagle_tmp_dir branch! Happy to share any of those files if you'd like

@nmerket
Copy link
Member Author

nmerket commented May 20, 2022

@mnblonsky Nice! Thanks for confirming it works. We will get this merged and in the main branch.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

File Coverage
All files 80%
base.py 81%
eagle.py 74%
exc.py 57%
localdocker.py 27%
postprocessing.py 84%
utils.py 96%
sampler/base.py 69%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 50%
test/test_validation.py 96%
workflow_generator/base.py 90%
workflow_generator/commercial.py 24%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 59%

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against 817a59a

@nmerket nmerket merged commit 538d06e into develop Oct 3, 2022
@nmerket nmerket deleted the eagle_tmp_dir branch October 3, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule file temp directory running out of memory on Eagle
3 participants