Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure all_ts_cols is always a set #263

Merged
merged 2 commits into from Feb 1, 2022
Merged

ensure all_ts_cols is always a set #263

merged 2 commits into from Feb 1, 2022

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Feb 1, 2022 •
edited

Fixes #261 .

Pull Request Description

When there is only one datapoint, the fold doesn't work and all_ts_cols remains a list which causes crash in subsequent statements. This fixes the issue by ensuring all_ts_cols is always a set.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@rajeee rajeee requested a review from nmerket February 1, 2022 15:25
nmerket
nmerket reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Can you put something in the changelog for this? Also, I realize I didn't have you put anything in the changelog for #258 and #262. Can you do that as well?

@rajeee
Copy link
Contributor Author

rajeee commented Feb 1, 2022

Seems reasonable. Can you put something in the changelog for this? Also, I realize I didn't have you put anything in the changelog for #258 and #262. Can you do that as well?

Sure. I forgot about changelogs!

@rajeee rajeee requested a review from nmerket February 1, 2022 15:57
nmerket
nmerket approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those.

@nmerket nmerket merged commit ab16269 into develop Feb 1, 2022
@nmerket nmerket deleted the fix_1_datapoint_fail branch February 1, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerket nmerket nmerket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postprocessing fails when there is only one datapoint.
2 participants
@rajeee @nmerket