Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim the buildstock.csv for each batch #246

Merged
merged 5 commits into from Sep 8, 2021
Merged

Trim the buildstock.csv for each batch #246

merged 5 commits into from Sep 8, 2021

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Sep 7, 2021

Makes simulation faster by reducing the size of buildstock.csv file.

Pull Request Description

Trims the buildstock.csv to include only rows for the current batch. Reduces the number of rows that need to be scanned by ResStock to find the entry for a given building.

Companion PR in ResStock: NREL/resstock#701
Corresponding fix for BSB AWS is here: https://github.com/NREL/buildstockbatch/pull/245/files

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@rajeee rajeee requested a review from nmerket September 7, 2021 22:25
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note to the changelog_dev.rst file?

@rajeee rajeee requested a review from nmerket September 8, 2021 01:04
@rajeee rajeee merged commit fcd7131 into develop Sep 8, 2021
@rajeee rajeee deleted the trim_buildstock branch September 8, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants