Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResStock - Inverse Sample Weight #234

Closed
afontani opened this issue May 27, 2021 · 0 comments · Fixed by #235
Closed

ResStock - Inverse Sample Weight #234

afontani opened this issue May 27, 2021 · 0 comments · Fixed by #235
Labels
bug Something isn't working

Comments

@afontani
Copy link
Collaborator

Issue description

The sample weight is inverse to what we would expect. In a recent run with BuildStock Batch 0.20 I used the following YAML inputs:

baseline:
  n_buildings_represented: 133172057 # ACS 5-yr 2016
sampler:
  type: residential_quota
  args:
    n_datapoints: 550000

I would expect the weight to be 33,172,057/550,000 = 242.13. However, the weight ended up being 0.00413 ~ 550,000/133,172,057.

Bug Location

I believe this is the issue in the ResStock workflow_generator.

'sample_weight': self.n_datapoints / self.cfg['baseline']['n_buildings_represented'],

@afontani afontani added the bug Something isn't working label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant