Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "pinning click<8" #232

Merged
merged 3 commits into from May 25, 2021
Merged

Revert "pinning click<8" #232

merged 3 commits into from May 25, 2021

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented May 14, 2021

This reverts commit d35397b.

Pull Request Description

We pinned an old version of click which was causing a dependency conflict in dask.distributed.
dask/distributed#4817

This undoes that as the latest version of dask.distributed 2021.5.0 fixes that issue.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Create an Eagle environment
  • Run a small batch run on Eagle to make sure it all works
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket merged commit 7f7e628 into develop May 25, 2021
@nmerket nmerket deleted the remove_click_pin branch May 25, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant