Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip upgrades without ts #230

Merged
merged 4 commits into from May 4, 2021
Merged

Skip upgrades without ts #230

merged 4 commits into from May 4, 2021

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented May 4, 2021 •
edited

Fixes #199.

Pull Request Description

While this was technically fixed in #212, this adds a test to prove it and a few other things.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket requested a review from rajeee May 4, 2021 19:33
@nmerket nmerket self-assigned this May 4, 2021
rajeee
rajeee approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@rajeee rajeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks for cleaning it up and adding tests.

@nmerket nmerket merged commit 6b0546d into develop May 4, 2021
@nmerket nmerket deleted the skip_upgrades_without_ts branch May 4, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeee rajeee rajeee approved these changes

Assignees

@nmerket nmerket

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postprocess timeseries fails when upgrade is not applicable to buildings
2 participants
@nmerket @rajeee