Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment create fix for 0.19 #227

Merged
merged 2 commits into from May 14, 2021
Merged

Environment create fix for 0.19 #227

merged 2 commits into from May 14, 2021

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented May 3, 2021 •
edited

Ports #226 to v0.19.

Checklist

Not all may apply

  • All other unit tests passing
  • Build environment on Eagle
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket self-assigned this May 3, 2021
@nmerket nmerket changed the base branch from develop to v0_19_patch May 3, 2021 15:24
@nmerket nmerket requested a review from rajeee May 3, 2021 15:25
rajeee
rajeee approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@rajeee rajeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine.

@nmerket
Copy link
Member Author

nmerket commented May 4, 2021

Waiting for Eagle system time to verify this works.

@nmerket nmerket merged commit 2c12f7e into v0_19_patch May 14, 2021
@nmerket nmerket deleted the env_create_fix_0_19 branch May 14, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeee rajeee rajeee approved these changes

Assignees

@nmerket nmerket

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmerket @rajeee