ResStock-HPXML

[joseph-robertson]

Pull Request Description

Closes NREL/resstock#725.

This is the companion PR to: NREL/resstock#443

• Remove include_timeseries_unmet_loads (Replaces Unmet Load outputs with Unmet Hours OpenStudio-HPXML#846)

Checklist

Not all may apply

• Code changes (must work)
• Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
• All other unit tests passing
• Update validation for project config yaml file changes
• Update existing documentation
• Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
• Add to the changelog_dev.rst file and propose migration text in the pull request

[nmerket]

That was fast. A few comments below.

[nmerket]

As we talked about we need to find a way (eventually) to make this dependent on which workflow you're using. Need to coordinate with ComStock.

[joseph-robertson]

@nmerket Idea: Pull openstudio version from resstock's __version__.py file? https://github.com/NREL/resstock/blob/develop/resources/__version__.py#L5

[joseph-robertson]

@nmerket @rajeee Maybe we can incorporate "new tests" on this branch? It's needed for resstock, and current tests are failing anyways.

[github-actions]

File	Coverage
All files	80%	✅
base.py	84%	✅
eagle.py	71%	✅
exc.py	57%	✅
localdocker.py	27%	✅
postprocessing.py	89%	✅
utils.py	96%	✅
sampler/base.py	69%	✅
sampler/downselect.py	33%	✅
sampler/precomputed.py	93%	✅
sampler/residential_quota.py	50%	✅
test/test_validation.py	97%	✅
workflow_generator/base.py	90%	✅
workflow_generator/commercial.py	24%	✅
workflow_generator/residential.py	96%	✅
workflow_generator/residential_hpxml.py	61%	✅

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against 5b6296a

[nmerket]

I think this looks good. It seems like you've been using it for a while now and it's working. There's some stuff I'd like to generalize more like bind mounts, but I think we can do that with another PR.