Fix: racially insensitive language #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmerket
reviewed
Jan 14, 2021
buildstockbatch/schemas/v0.1.yaml
Outdated
Comment on lines
36
to
38
| master_instance_type: str(required=False) | ||
| slave_instance_type: str(required=False) | ||
| slave_instance_count: int(min=1, required=False) | ||
| manager_instance_type: str(required=False) | ||
| worker_instance_type: str(required=False) | ||
| worker_instance_count: int(min=1, required=False) |
There was a problem hiding this comment.
We shouldn't be changing old schemas as the only function they serve now is to keep a record of previous input formats.
There was a problem hiding this comment.
Makes sense, addressed in 517049d
buildstockbatch/schemas/v0.2.yaml
Outdated
Comment on lines
38
to
40
| master_instance_type: str(required=False) | ||
| slave_instance_type: str(required=False) | ||
| slave_instance_count: int(min=1, required=False) | ||
| manager_instance_type: str(required=False) | ||
| worker_instance_type: str(required=False) | ||
| worker_instance_count: int(min=1, required=False) |
There was a problem hiding this comment.
Same here. Since we're making breaking changes to the input format, we should make a v0.3 schema and upgrade to that. I actually have a v0.3 schema going on in #187. Maybe we should wait for that to merge (soon) and make these changes there.
There was a problem hiding this comment.
Addressed in 517049d. That sounds good, we can hold off for the next schema to get merged.
nmerket
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164
Pull Request Description
Removes racially insensitive language for EMR instance types, updating the following arguments:
master_instance_type==>manager_instance_typeslave_instance_type==>worker_instance_typeslave_instance_count==>worker_instance_countAlso, now fixes the broken AWS workflow.
Checklist
Not all may apply