Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinning s3fs version for AWS postprocessing #188

Merged
merged 1 commit into from Oct 21, 2020
Merged

Pinning s3fs version for AWS postprocessing #188

merged 1 commit into from Oct 21, 2020

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Oct 13, 2020 •
edited

Pull Request Description

The most recent version of s3fs was causing dependency problems in the EMR bootstrap script. This pins it to an older, working version.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket added the bug Something isn't working label Oct 13, 2020
@nmerket nmerket requested a review from vtnate October 13, 2020 17:59
@nmerket nmerket self-assigned this Oct 13, 2020
vtnate
vtnate approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@vtnate vtnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking care of business

@nmerket nmerket merged commit 6c6ad8a into develop Oct 21, 2020
@nmerket nmerket deleted the emr_dependency_fix branch October 21, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtnate vtnate vtnate approved these changes

Assignees

@nmerket nmerket

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmerket @vtnate