Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dependency issue on Eagle installation #179

Merged
merged 2 commits into from Aug 26, 2020
Merged

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Aug 26, 2020

Fixes #178.

Pull Request Description

A recent update to s3fs was causing dependency conflicts with boto3, so I pinned it to the older version that worked.

Installed in a new environment on Eagle and tested with a small batch run. Seems to work.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket added bug Something isn't working eagle labels Aug 26, 2020
@nmerket nmerket requested a review from asparke2 August 26, 2020 18:34
Copy link
Member

@asparke2 asparke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just successfully built and used an environment created with this code on Eagle.

@nmerket nmerket merged commit 91e3ade into develop Aug 26, 2020
@nmerket nmerket deleted the eagle_install_fix branch August 26, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working eagle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issue in setup.py as of 8/26/2020
2 participants