Bldgs represented arg #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmerket Was it correct to update the |
nmerket
reviewed
Aug 26, 2020
docs/changelog/migration_0_18.rst
Outdated
Comment on lines
83
to
84
| key, and ``buildstock_csv`` needs to be changed to ``precomputed_sample``. The new schema would now look like: | ||
| key, the ``n_buildings_represented`` key, and ``buildstock_csv`` needs to be changed to ``precomputed_sample``. The new schema would now look like: |
There was a problem hiding this comment.
Rather than change this here, you'll want to document this change in
https://github.com/NREL/buildstockbatch/blob/bldgs_represented_arg/docs/changelog/changelog_dev.rst
nmerket
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Makes the
n_buildings_representedargument required in the0.2yml schema. Prior to this, if the argument was not included, no simulations would run, and the only error output would be a post-processing error, and therefore very difficult to debug.Checklist
Not all may apply