Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing dependency problem with ruamel.yaml for aws #176

Merged
merged 1 commit into from Aug 21, 2020
Merged

Fixing dependency problem with ruamel.yaml for aws #176

merged 1 commit into from Aug 21, 2020

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Aug 20, 2020

Pull Request Description

There was some dependency problem with ruamel.yaml when building the docker container to run on AWS. This fixes that.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket added bug Something isn't working aws needs review labels Aug 20, 2020
@nmerket nmerket self-assigned this Aug 20, 2020
vtnate
vtnate approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@vtnate vtnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🐋

@vtnate
Copy link
Contributor

vtnate commented Aug 21, 2020

Thank you @nmerket for fixing this so quickly!

@nmerket nmerket merged commit aa9383e into develop Aug 21, 2020
@nmerket nmerket deleted the docker_build_ruamel_fix branch August 21, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtnate vtnate vtnate approved these changes

@TobiAdekanye TobiAdekanye Awaiting requested review from TobiAdekanye

Assignees

@nmerket nmerket

Labels
aws bug Something isn't working needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmerket @vtnate