Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly importing remove_intermediate_files #163

Merged
merged 6 commits into from Jun 17, 2020
Merged

properly importing remove_intermediate_files #163

merged 6 commits into from Jun 17, 2020

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Jun 11, 2020

Pull Request Description

AWS postprocessing failure fix

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

vtnate
vtnate previously approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@vtnate vtnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed successful with the current master of OS-Buildstock. Great work on that stupid AWS issue.

@nmerket nmerket merged commit 2e99aa1 into master Jun 17, 2020
@nmerket nmerket deleted the aws_postprocessing_fix branch June 17, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtnate vtnate vtnate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmerket @vtnate